Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename _build_index to build_byte_index #142

Merged
merged 5 commits into from Feb 5, 2024
Merged

Conversation

levitsky
Copy link
Owner

@levitsky levitsky commented Feb 1, 2024

Fixes #140.

  • unified method name is now build_byte_index across all indexed and index-saving parsers;
  • the method returns the index rather than assign it (the behavior of build_byte_index is preserved);
  • warning is thrown when defining an IndexedXML subclass with a _build_index method (Python 3 only).

@mobiusklein could you please take a look at it?

@levitsky levitsky changed the title Rename _build_index to build_byte_offset Rename _build_index to build_byte_index Feb 1, 2024
Copy link
Contributor

@mobiusklein mobiusklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small change that I'll make in my downstream code to account for https://github.com/levitsky/pyteomics/pull/142/files#diff-7326fe871ea5482e4c336e02fabaa716957ab8aa12670f129c09d95d26630cceR538, but this looks good to me.

@levitsky levitsky merged commit 595053e into master Feb 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexSavingMixin._build_index() is never called by text parsers?
2 participants