Fix dist target and update the README #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicwortel
suggested changes
Jun 15, 2018
There was a problem hiding this comment.
Maybe we should replace the "Packagist version" badge from the README with the "GitHub release" badge from https://shields.io/, and link it to https://github.com/leviy/release-tool/releases/latest.
README.md
Outdated
| Install this package using [Composer](https://getcomposer.org/): | ||
|
|
||
| ### PHAR | ||
| The recommended method of installing this package is using a PHAR file. This is because installing using Composer can possibly cause dependency conflicts. You can download the most recent PHAR from the [Github Releases](https://github.com/leviy/release-tool/releases) page. |
There was a problem hiding this comment.
There is actually a https://github.com/leviy/release-tool/releases/latest URL that redirects to the latest release.
README.md
Outdated
| @@ -14,7 +14,12 @@ your machine. | |||
|
|
|||
| ## Installation | |||
|
|
|||
| Install this package using [Composer](https://getcomposer.org/): | |||
|
|
|||
| ### PHAR | |||
There was a problem hiding this comment.
The PHP documentation as well as Composer write "phar" as a lowercase word. I think we should do the same (or "Phar" in this case because it is at the start of a sentence).
README.md
Outdated
| The recommended method of installing this package is using a PHAR file. This is because installing using Composer can possibly cause dependency conflicts. You can download the most recent PHAR from the [Github Releases](https://github.com/leviy/release-tool/releases) page. | ||
|
|
||
| ### Composer | ||
| You can install this package using [Composer](https://getcomposer.org/): |
There was a problem hiding this comment.
Perhaps "Alternatively, you can ..."
josephineb
force-pushed
the
master_phar-download
branch
2 times, most recently
from
6d7314c
to
6e70ca9
Compare
josephineb
force-pushed
the
master_phar-download
branch
from
6e70ca9
to
677ea12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29