Use Behat to test different scenarios with semantic versioning #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BasMatthee
suggested changes
Jul 6, 2018
| */ | ||
| private function selectVersionType(string $type): void | ||
| { | ||
| if ($type === 'major') { |
There was a problem hiding this comment.
I am always more fond of a switch-statement with these kinds of if-elseif-elseif-elseif-else-statements. Just taste-wise.
features/semantic-versioning.feature
Outdated
| Feature: Calculating a version number based on semantic versioning | ||
|
|
||
| Scenario: Releasing a major version | ||
| Given a release on this branch with version "1.0.0" |
There was a problem hiding this comment.
I had to read this line a few times to understand
Given the latest release on this branch is x.x.xGiven the latest tag on this branch is x.x.x
features/semantic-versioning.feature
Outdated
| Scenario: Releasing a patch version | ||
| Given a release on this branch with version "1.0.9" | ||
| When I release a new patch version | ||
| Then version "1.0.10" should be released |
There was a problem hiding this comment.
Not all cases (that seem common sense from a developers perspective) are present.
Does a major release from 1.0.1 really go to 2.0.0? Etc.
We might need some tests for the following cases.
- 1.0.1 > major > 2.0.0
- 1.1.0 > major > 2.0.0
- 1.1.1 > minor > 1.2.0
- 1.1.1 > patch > 1.1.2
And what happens when I release a patch or minor on 2.0.0-beta.2?
BasMatthee
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.