Remove development dependencies from the compiled PHAR #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Release Tool has moved from being a library to being a PHAR distributed command-line application, it makes sense to commit the composer.lock. This also allows us to depend on the composer.lock to exist when running Box (which needs the composer.lock to remove dev dependencies).
This significantly reduces the size of the compiled PHAR.
theofidry
reviewed
Aug 24, 2018
box.json
Outdated
| @@ -1,13 +1,7 @@ | |||
| { | |||
| "chmod": "0755", | |||
There was a problem hiding this comment.
with the last update IIRC this mode is now the default so could be removed
theofidry
reviewed
Aug 24, 2018
box.json
Outdated
| "LICENSE.txt", | ||
| "README.md" | ||
| "directories-bin": [ | ||
| "config" | ||
| ], | ||
| "git-version": "package_version", | ||
| "main": "bin/release", |
There was a problem hiding this comment.
stub: true can be removed as well since it's the default value
theofidry
reviewed
Aug 24, 2018
box.json
Outdated
| "LICENSE.txt", | ||
| "README.md" | ||
| "directories-bin": [ | ||
| "config" | ||
| ], | ||
| "git-version": "package_version", | ||
| "main": "bin/release", |
There was a problem hiding this comment.
since bin/release is configured as a bin file in composer.json, this config entry is unnecessary as well; the output one is however since the output name differs from the input one
There was a problem hiding this comment.
Thank you for reviewing! I've implemented your suggestions.
nicwortel
force-pushed
the
cleanup-phar
branch
from
c80e4b9
to
e5da1f5
Compare
josephineb
approved these changes
Aug 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #47.
This reduces the size of the PHAR from 18.5 MB to 2.3 MB. Thanks to @theofidry for the suggestion and help.
See https://github.com/leviy/release-tool/pull/35/files/e6fe1a69beada77909a0d4816e5fec4ed8637a33#r199961790