Don't sign commits during automated tests #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apart from the fact that automated commits shouldn't be signed by the user running them in the first place, this reduces the time it takes to run the test suite (`time make check` shows a decline from 18.625 seconds to 2.562 seconds).
nicwortel
force-pushed
the
dont-sign-commits
branch
from
15451d4
to
ed4c7b6
Compare
VSlokker
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people (such as me) have the Git setting
commit.gpgsignset to true, which means that all commits will automatically be signed by a GPG key. This also applies to commits made in the automated tests of this repository.Apart from the fact that automated commits shouldn't be signed by the user running them in the first place, disabling it reduces the time it takes to run the test suite (
time make checkshows a decline from 18.625 seconds to 2.562 seconds).