Update box.json to not exclude Changelog.php #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicwortel
force-pushed
the
fix-missing-file-in-phar
branch
4 times, most recently
from
ce308c6
to
c880500
Compare
Unfortunately, this is also the case for Travis CI.
nicwortel
force-pushed
the
fix-missing-file-in-phar
branch
from
c880500
to
07350ea
Compare
The file Changelog.php was excluded from the built PHAR by Box, because it matched with one of the rules detecting development files. By explicitly adding the "src" directory, but also forcing autodiscovery, we include the file in our build while still profiting of Box's file autodiscovery features.
josephineb
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.