Support and compatibility added for PHP 8.1 #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@christiaan @josephineb @VSlokker Hi 👋 It's me 😄 |
|
@denniscoorn sorry to have missed this. Looking good; can you maybe fix the conflicts? I cannot because they are on your fork. |
christiaan
previously approved these changes
Aug 28, 2023
|
@christiaan Thanks for the review! I've resolved the conflicts and also updated |
christiaan
approved these changes
Sep 6, 2023
|
Nope, all good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've upgraded a couple of packages, fixed some coding standard violations (due to package upgrades) and refreshed the workflows a little bit.
In order to add support for PHP 8.1 I had to bump the minimum supported version to 7.4. This will be a backward compatibility break but I would highly suggest to take the version bump, otherwise it will be very difficult to mitigate future security vulnerabilities and is it impossible to add support for any PHP version higher than 8.0.
I replaced the package
padraic/phar-updaterwithconsolidation/self-updateto remove a security vulnerability in packagepadraic/humbug_get_contentsand to make it easier to support PHP 8.1. In general theself-updatecommand works the same as it is now, except for the--rollbackoption, but I guess that would be an acceptable trade off.Here's a list of all packages that are being upgraded:
phpstan/phpstan(0.12.93 => 1.9.14)behat/behat(v3.8.1 => v3.12.0)behat/gherkin(v4.8.0 => v4.9.0)behat/transliterator(v1.3.0 => v1.5.0)squizlabs/php_codesniffer(3.6.0 => 3.7.1)phpmd/phpmd(2.10.2 => 2.13.0)pdepend/pdepend(2.10.0 => 2.12.1)composer/xdebug-handler(2.0.1 => 3.0.3)phpspec/prophecy(v1.15.0 => v1.16.0)psr/container(1.1.1 => 1.1.2)symfony/config(v5.3.3 => v5.4.11)symfony/console(v5.3.2 => v5.4.17)symfony/dependency-injection(v5.3.3 => v5.4.17)symfony/deprecation-contracts(v2.4.0 => v2.5.2)symfony/event-dispatcher(v5.3.0 => v5.4.17)symfony/event-dispatcher-contracts(v2.4.0 => v2.5.2)symfony/filesystem(v5.4.13 => v5.4.13)symfony/polyfill-ctype(v1.24.0 => v1.27.0)symfony/polyfill-intl-grapheme(v1.23.0 => v1.27.0)symfony/polyfill-php73(v1.23.0 => v1.27.0)symfony/polyfill-php80(v1.23.0 => v1.27.0)symfony/polyfill-php81(v1.23.0 => v1.27.0)symfony/process(v5.3.2 => v5.4.11)symfony/service-contracts(v2.4.0 => v2.5.2)symfony/string(v5.3.3 => v5.4.17)symfony/translation(v5.3.3 => v5.4.14)symfony/translation-contracts(v2.4.0 => v2.5.2)symfony/yaml(v5.3.3 => v5.4.17)These packages are being removed:
padraic/phar-updater(v1.0.6)padraic/humbug_get_contents(1.1.2)