Startup improvements & PAUSE/RESUME #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levkk
commented
Jan 28, 2023
| @@ -136,10 +139,14 @@ pub struct ConnectionPool { | |||
| /// The server information (K messages) have to be passed to the | |||
| /// clients on startup. We pre-connect to all shards and replicas | |||
| /// on pool creation and save the K messages here. | |||
| server_info: BytesMut, | |||
| server_info: Arc<RwLock<BytesMut>>, | |||
There was a problem hiding this comment.
This gets only read when a new client connects, so it should not have an contention on it.
levkk
commented
Jan 28, 2023
src/pool.rs
Outdated
|
|
||
| /// If not validated, we need to double check the pool is available before allowing a client | ||
| /// to use it. | ||
| pub validated: Arc<AtomicBool>, |
There was a problem hiding this comment.
Same here. Atomics are also really fast.
levkk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAUSE/RESUMEFix #254
Fix #177