-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/accept objects and paths to files #89
Feature/accept objects and paths to files #89
Conversation
Is there a reason why this PR isn't being merged? The changes are pretty sensible. Using a non-file method of authentication makes sense for CI/CD implementations (like ours) which manage them via environment variables. |
Even though the PR looks great, I didn't have a chance to test it in a CI/CD environment. @dreilly-icf can you confirm it works for you? |
Hi @levz0r - first off-- thanks for the question and this fantastic package. It's enabled our automation project in ways we've just begun to comprehend. I can presently confirm this PR works with the credentials/token passed as a string. I'm currently working on implementing the pipelines, but the first piece is done. There's a couple more steps I need to take on the devops side, but as long as we set up the resources correctly, Cypress won't know the difference between a pipeline execution and a local one. Here's our general flow:
Since we haven't committed our All this is to say, if it works locally, it should work in our pipelines. Either way, I can provide positive confirmation when our pipelines are implemented in case anything sneaks up. |
@levz0r - I've set up the secrets and all necessary resources within our pipeline. I can, indeed, confirm it works. output:
As you can see, our docker container has spun up successfully. This was part of our build pipeline which retrieves the docker container. After downloading, the run begins:
The test itself:
So.. there you have it. We did have to make some tweaks, namely, downloading @MatteoMolinari93 feature branch to a local repo and modifying our After all is said and done, though, I hope we've demonstrated the validity of this PR. |
Thank you for the detailed information David, and thank you @MatteoMolinari93 for the PR. Merging it now. |
I'd be glad to! If the write-up above is good, I'll work it into a .md file and open a PR for it. It seems most have figured out that they could take the "workaround" approach by retrieving the string and writing to a file, but if my example helps anyone better understand how this is accomplished, I'd be glad to help. Thanks for your quick response and, again, for making something that provided real value to my team. |
Hi @levz0r - Sorry to be a bother.. is there a plan to release this change on NPM as a new package version? Not sure what the process entails. Thanks! |
Just released a new version on NPM. Thank you. |
#71