Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing libgtk2 package and fix Xming config #73

Closed
wants to merge 2 commits into from

Conversation

paulgaumer
Copy link

  1. Installing libgtk2.0 is necessary because it’s not installed by default with the WSL version of Ubuntu. Without this package, trying to launch Sublime Text would raise errors

  2. The echo "export DISPLAY=:0" >> ~/.zshrc was originally called before installing zsh. Trying to launch Sublime Text wouldn't do anything. Moved the command to the end of the zsh setup

1) Installing libgtk2.0 is necessary because it’s not installed by default with the WSL version of Ubuntu. Without this package, trying to launch Sublime Text would raise errors

2) The `echo "export DISPLAY=:0" >> ~/.zshrc` was originally called before installing zsh. Trying to launch Sublime Text wouldn't  do anything. Moved the command to the end of the zsh setup
@ssaunier
Copy link
Member

ssaunier commented Oct 8, 2018

Thanks @paulgaumer! I can't merge it as is because of the way the repo works

Thanks!

@mdik
Copy link
Contributor

mdik commented Oct 8, 2018

I have the feeling that the export DISPLAY line gets lost during oh-my-zsh install, so I would move it further back.

@mdik
Copy link
Contributor

mdik commented Oct 8, 2018

I don't see libgtk2.0 but only libgtk2.0-0 as package?

@mdik mdik mentioned this pull request Oct 8, 2018
@paulgaumer
Copy link
Author

paulgaumer commented Oct 10, 2018

I don't see libgtk2.0 but only libgtk2.0-0 as package?

libgtk2.0 worked when I ran it, but libgtk2.0-0 was indeed referenced in other articles and might be more accurate

@barangerbenjamin
Copy link
Contributor

Fix #72 and #71

@ssaunier
Copy link
Member

ssaunier commented Dec 4, 2018

@barangerbenjamin can you update the source files so that when we compile with build.rb we don't override those changes (I can't merge as is).

Thanks.

@db0sch
Copy link
Contributor

db0sch commented Jan 10, 2019

This PR has been replaced by this one #90 as i couldn't access the @paulgaumer 's branch.
Thank you all 🙏

@db0sch db0sch closed this Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants