Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option parsing misses '-p' #9

Closed
sbeitzel opened this issue Oct 24, 2017 · 3 comments
Closed

Option parsing misses '-p' #9

sbeitzel opened this issue Oct 24, 2017 · 3 comments

Comments

@sbeitzel
Copy link
Contributor

The command line argument processing doesn't detect the -p switch. For example:

[sbeitzel@PirateBook ~/src/github/abcm2ps]$ ./abcm2ps -p sample.abc
abcm2ps-8.13.16 (2017-10-24)
error: Unknown flag: -p ignored
File sample.abc

I'm attaching a patch which fixes this:
pipeformat_patch.txt

@moinejf
Copy link
Collaborator

moinejf commented Oct 25, 2017

Fixed. Thanks.

@sbeitzel
Copy link
Contributor Author

Yep, that does the job.

Out of curiosity, why doesn't this application use getopt for parsing the options?

@moinejf
Copy link
Collaborator

moinejf commented Oct 25, 2017

This an old application, started almost 20 years ago, which was also working in M$-DOS.
Then, as the command line arguments may be complex (global parameters + files + possible parameters for each file), it is simpler to parse them manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants