Add flag to force bagpipe formatting #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# By Lee Savide (6) and others # Via laughingman182 * 'dev' of github.com:laughingman182/abcm2ps: abcm2ps-8.3.0 abcm2ps-8.2.2 abcm2ps-8.1.5 abcm2ps-8.1.4 abcm2ps-8.1.2 abcm2ps-8.0.4 abcm2ps-8.0.3 abcm2ps-8.0.2 abcm2ps-7.7.2 abcm2ps-7.6.10 Conflicts: abc2ps.c parse.c
Conflicts: config.h
|
The problem with adding merge requests to this particular project is that it's more so meant to be like the vim-scripts repositories: this project's purpose is first most to teach changes over a project that has no version control system available to its original maintainer. I would rather you send these changes to those responsible for editing the code: http://moinejf.free.fr/ |
This was referenced Apr 13, 2018
This was referenced Jul 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #1. The command line switch '-p' will force the rendering code to treat grace notes and note stems as if the key were a type of bagpipe, even if it is not (e.g. K:D).
From a code review standpoint, I'm not proud of this patch. It feels dirty to have a command line switch to do this formatting. I still think the right way to do this is to provide an ABC formatting directive, but this gets the job done right now so I can print tunes for my band.