fix(actions.show): check buffer is attached

Fixes #865
lewis6991 · Aug 31, 2023 · 44adf80 · 44adf80
1 parent d8b52fc
commit 44adf80
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lua/gitsigns/actions.lua b/lua/gitsigns/actions.lua
@@ -1079,8 +1079,13 @@ CP.diffthis = complete_heads
 --- Attributes: ~
 ---     {async}
 M.show = function(revision)
+  local bufnr = api.nvim_get_current_buf()
+  if not cache[bufnr] then
+    print('Error: Buffer is not attached.')
+    return
+  end
   local diffthis = require('gitsigns.diffthis')
-  diffthis.show(revision)
+  diffthis.show(bufnr, revision)
 end
 
 CP.show = complete_heads

diff --git a/lua/gitsigns/diffthis.lua b/lua/gitsigns/diffthis.lua
@@ -160,9 +160,9 @@ M.diffthis = async.void(function(base, opts)
   api.nvim_set_current_win(cwin)
 end)
 
+--- @param bufnr integer
 --- @param base string
-M.show = async.void(function(base)
-  local bufnr = api.nvim_get_current_buf()
+M.show = async.void(function(bufnr, base)
   local bufname = create_show_buf(bufnr, base)
   if not bufname then
     return