Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot resolve symbol 'xdl_diff' #90

Closed
Shatur opened this issue Mar 15, 2021 · 3 comments
Closed

Cannot resolve symbol 'xdl_diff' #90

Shatur opened this issue Mar 15, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@Shatur
Copy link

Shatur commented Mar 15, 2021

Describe the bug
On Windows after a98df15 the plugin doesn't work.

To Reproduce

Just install plugin and run Neovim, you will see the following error:

...im\pack\plugins\opt\gitsigns.nvim\lua\gitsigns\async.lua:53: ...vim\pack\plugins\opt\gitsigns.nvim\lua\gitsigns\diff.lua:130: cannot resolve symbol 'xdl_diff'.

Observed output
Error messages, logs, etc

Screenshots
If applicable, add screenshots to help explain your problem or to capture error messages.

Additional context
System: Windows
Neovim version: gf5daf55c1 (latest master at the time of writing).

@Shatur Shatur added the bug Something isn't working label Mar 15, 2021
@lewis6991
Copy link
Owner

Looks like your windows install doesn't have access to xdl_diff which is interesting. As a workaround you can revert to the old behavior with:

config.use_internal_diff = false.

lewis6991 added a commit that referenced this issue Mar 15, 2021
@lewis6991
Copy link
Owner

Looks like ffi on windows is a bit tricky: https://stackoverflow.com/questions/5919743/how-to-use-luajits-ffi-module-when-embedding

For now we can automatically disable internal diff on windows.

@Shatur
Copy link
Author

Shatur commented Mar 15, 2021

Interesting. As I know, https://github.com/kyazdani42/nvim-tree.lua uses ffi two and works for me on Windows.

But thanks for the reasonable default for now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants