Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: change default of attached_to_untracked to false #936

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

lewis6991
Copy link
Owner

No description provided.

@lewis6991 lewis6991 force-pushed the defaultatu branch 2 times, most recently from b939afc to d429a27 Compare January 25, 2024 16:02
@lewis6991 lewis6991 merged commit 590d077 into main Jan 25, 2024
6 checks passed
@lewis6991 lewis6991 deleted the defaultatu branch January 25, 2024 16:48
@jwhitley
Copy link

jwhitley commented Jan 25, 2024

FYI, this changed a default, but didn't update the default for attached_to_untracked in README.md (still says true).

@savchenko

This comment has been minimized.

@lewis6991

This comment has been minimized.

@savchenko
Copy link

Look at the contents of the PR

I was clearly looking at something else... Sorry about that.

@bew
Copy link

bew commented Jan 26, 2024

I'm curious, what's the reasoning behind this change of default? (if there is one)

@lewis6991
Copy link
Owner Author

I got feedback from multiple people that they hated it and I understood their reasoning. Fwiw I'll still continue to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants