Prevent crash where createdAt is not returned

[boc-the-git]

I will admit this isn't extensively tested because I don't know the overall solution too well, but I can confirm this fixes the issue as reported here: https://community.home-assistant.io/t/amber-electric-australia-custom-component/201231/18

[stuarts0011]

Hi boc - This did not resolve the problem for me? I'm still getting exactly the same error log.

[boc-the-git]

What post code Stuart?

…

On Mon, 20 Jul 2020, 14:24 stuarts0011, ***@***.***> wrote: Hi boc - This did not resolve the problem for me? I'm still getting exactly the same error log. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA2RMNCGMBMWS3NCP4K7KPDR4PBG7ANCNFSM4OXCD62Q> .

[stuarts0011]

2069 Sometimes it will load the platform, sometimes not.

…

On Mon, 20 Jul 2020, 3:04 pm boc-the-git, ***@***.***> wrote: What post code Stuart? On Mon, 20 Jul 2020, 14:24 stuarts0011, ***@***.***> wrote: > Hi boc - This did not resolve the problem for me? I'm still getting > exactly the same error log. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > < #9 (comment) >, > or unsubscribe > < https://github.com/notifications/unsubscribe-auth/AA2RMNCGMBMWS3NCP4K7KPDR4PBG7ANCNFSM4OXCD62Q > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AM3WSCS6EPQMOT53HKICVZLR4PF5TANCNFSM4OXCD62Q> .

[boc-the-git]

2069 Sometimes it will load the platform, sometimes not.

I've tested with 2069 and no issue. As you say it sometimes works and sometimes doesn't, can you look to supply more info next time it crashes? Without more info, I can only assume it's unrelated.

It would also be useful to get the output from this.. please create a python script with this and run it:

import requests
import json

URL = "https://api.amberelectric.com.au/prices/listprices"

response = requests.post(URL, '{"postcode":"2069"}')

print(response.content)

[stuarts0011]

If the error exists on reboot, it won't load the platform as here:

"Log Details (ERROR)
Logger: homeassistant.components.sensor
Source: custom_components/amberelectric/ambermodel.py:41
Integration: Sensor (documentation, issues)
First occurred: 17:54:18 (1 occurrences)
Last logged: 17:54:18

Error while setting up amberelectric platform for sensor
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 178, in _async_setup_platform
await asyncio.wait_for(asyncio.shield(task), SLOW_SETUP_MAX_WAIT)
File "/usr/local/lib/python3.7/asyncio/tasks.py", line 442, in wait_for
return fut.result()
File "/usr/local/lib/python3.7/concurrent/futures/thread.py", line 57, in run
result = self.fn(*self.args, **self.kwargs)
File "/config/custom_components/amberelectric/sensor.py", line 45, in setup_platform
AmberPricingSensor(amber_data, postcode, CONST_SOLARFIT, "Amber solar feed in tariff", "mdi:solar-power"),
File "/config/custom_components/amberelectric/sensor.py", line 62, in init
self.update()
File "/usr/src/homeassistant/homeassistant/util/init.py", line 239, in wrapper
result = method(*args, **kwargs)
File "/config/custom_components/amberelectric/sensor.py", line 157, in update
self.amber_data = AmberData.from_dict(json.loads(response.text))
File "/config/custom_components/amberelectric/ambermodel.py", line 437, in from_dict
data = Data.from_dict(obj.get("data"))
File "/config/custom_components/amberelectric/ambermodel.py", line 400, in from_dict
VariablePricesAndRenewable.from_dict, obj.get("variablePricesAndRenewables")
File "/config/custom_components/amberelectric/ambermodel.py", line 51, in from_list
return [f(y) for y in x]
File "/config/custom_components/amberelectric/ambermodel.py", line 51, in
return [f(y) for y in x]
File "/config/custom_components/amberelectric/ambermodel.py", line 315, in from_dict
created_at = from_datetime(obj.get("createdAt"))
File "/config/custom_components/amberelectric/ambermodel.py", line 41, in from_datetime
return dateutil.parser.parse(x)
File "/usr/local/lib/python3.7/site-packages/dateutil/parser/_parser.py", line 1374, in parse
return DEFAULTPARSER.parse(timestr, **kwargs)
File "/usr/local/lib/python3.7/site-packages/dateutil/parser/_parser.py", line 646, in parse
res, skipped_tokens = self._parse(timestr, **kwargs)
File "/usr/local/lib/python3.7/site-packages/dateutil/parser/_parser.py", line 725, in _parse
l = _timelex.split(timestr) # Splits the timestr into tokens
File "/usr/local/lib/python3.7/site-packages/dateutil/parser/_parser.py", line 207, in split
return list(cls(s))
File "/usr/local/lib/python3.7/site-packages/dateutil/parser/_parser.py", line 76, in init
'{itype}'.format(itype=instream.class.name))
TypeError: Parser must be a string or character stream, not NoneType
Connection lost. Reconnecting…"

If it happens after successfully loading the platform, it just doesn't return data on that request.

[stuarts0011]

The output from your python above is as expected.

[boc-the-git]

Thanks for the extra information @stuarts0011

What I can infer from that is you are not running my code. I guess this is why you are getting the exact same (to the line of code) error message as my original error - because it was before my code change.

Your error message referencing line 315 of ambermodel.py is referencing the current/original code, not my modified code. If you update your ambermodel.py as per my change (see the 'Files changed' tab), you should no longer get the error.

[stuarts0011]

Thanks for the extra information @stuarts0011

What I can infer from that is you are not running my code. I guess this is why you are getting the exact same (to the line of code) error message as my original error - because it was before my code change.

Your error message referencing line 315 of ambermodel.py is referencing the current/original code, not my modified code. If you update your ambermodel.py as per my change (see the 'Files changed' tab), you should no longer get the error.

Hahaa. I left the original line 315 in and added your extra lines, but I realise I was meant to delete the original line 315. Sorry and thanks.

[boc-the-git]

No worries @stuarts0011 ! I'll assume that my change does fix your issue then unless we hear otherwise :)