Cope with deleted users and WP changes to get_userdata()

lewismcarey · Jan 15, 2013 · 85e5969 · 85e5969
1 parent 3014239
commit 85e5969
Showing 1 changed file with 22 additions and 19 deletions.
diff --git a/users_field.php b/users_field.php
@@ -404,28 +404,31 @@ function get_value_for_api( $post_id, $field ) {
 
 			}
 
-			if ( is_array( $value ) ) {
+			foreach ( $value as $k => $v ) {
 
-				foreach( $value as $k => $v ) {
+				$user_data = get_userdata( $v );
 
-					$user_data = get_userdata( $v );
-					$value[$k] = array();
-					$value[$k]['ID'] = $v;
-					$value[$k]['user_firstname'] = $user_data->user_firstname;
-					$value[$k]['user_lastname'] = $user_data->user_lastname;
-					$value[$k]['nickname'] = $user_data->nickname;
-					$value[$k]['user_nicename'] = $user_data->user_nicename;
-					$value[$k]['display_name'] = $user_data->display_name;
-					$value[$k]['user_email'] = $user_data->user_email;
-					$value[$k]['user_url'] = $user_data->user_url;
-					$value[$k]['user_registered'] = $user_data->user_registered;
-					$value[$k]['user_description'] = $user_data->user_description;
-
-				}
+				//cope with deleted users by @adampope
+				if ( ! is_object( $user_data ) ) {
 
-			} else {
-
-				$value = get_userdata( $value );
+					unset( $value[$k] );
+
+					continue;
+
+				}
+
+				$value[ $k ] = array();
+				$value[ $k ]['ID'] = $v;
+				$value[ $k ]['user_firstname'] = $user_data->user_firstname;
+				$value[ $k ]['user_lastname'] = $user_data->user_lastname;
+				$value[ $k ]['nickname'] = $user_data->nickname;
+				$value[ $k ]['user_nicename'] = $user_data->user_nicename;
+				$value[ $k ]['display_name'] = $user_data->display_name;
+				$value[ $k ]['user_email'] = $user_data->user_email;
+				$value[ $k ]['user_url'] = $user_data->user_url;
+				$value[ $k ]['user_registered'] = $user_data->user_registered;
+				$value[ $k ]['user_description'] = $user_data->user_description;
+				$value[ $k ]['user_avatar'] = get_avatar( $v );
 
 			}