Skip to content

Commit

Permalink
feat: create legacy icon theme (#7)
Browse files Browse the repository at this point in the history
also:
- address issues with the publish workflow
- rename file.svg icons to document.svg
- change launch configuration to open the workspace's parent folder
  rather than the .git folder (in order to test a variety of icons)
- remove unnecessary 'image' path from 'static' directory
  • Loading branch information
lewxdev committed Mar 16, 2024
1 parent de23276 commit 79354ca
Show file tree
Hide file tree
Showing 16 changed files with 815 additions and 16 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@ jobs:
- run: |
npm exec vsce package
echo "filepath=$(ls *.vsix)" >> $GITHUB_ENV
echo "version=$(npm pkg get version)" >> $GITHUB_ENV
echo "preview=$(npm pkg get preview)" >> $GITHUB_ENV
echo "version=$(npm pkg get version | tr -d \")" >> $GITHUB_ENV
- if: ${{ !github.event.inputs.no-publish }}
env:
Expand All @@ -42,4 +41,4 @@ jobs:

- env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: gh release create v$version $filepath --generate-notes --prerelease=$preview
run: gh release create v$version $filepath --generate-notes
2 changes: 1 addition & 1 deletion .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"type": "extensionHost",
"request": "launch",
"args": [
"${workspaceFolder}/.git",
"${workspaceFolder}/..",
"--disable-extensions",
"--extensionDevelopmentPath=${workspaceFolder}"
]
Expand Down
20 changes: 18 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ and this project adheres to

### Added

- New **Glyph (Legacy)** icon theme contribution (all icons from the original
Spectrum Icon extension)
- New **Glyph** icon theme contribution (the full set of icons available, a
kitchen sink of sorts)
- Color settings available for fine-tuning the icon colors (with some presets)
Expand All @@ -21,6 +19,24 @@ and this project adheres to
- Update icons to use a `.woff` icon font rather than `.svg` files to make it
easier to create new icon theme contributions with more customization

## [0.2.0] - 2024-03-15

### Added

- New **Glyph (Legacy)** icon theme contribution (all icons from the original
Spectrum Icon extension)
([#7](https://github.com/lewxdev/vscode-glyph/pull/7))

### Changed

- Promoted the extension out of preview status 🎉
- Updated social preview image with the new icon changes included

### Fixed

- Gear icon outermost stroke not rendering correctly (also improved the shape
and size of the icon)

## [0.1.2] - 2024-03-15

### Fixed
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@

</div>

![Social preview](static/image/social-preview.png)
![Social preview](static/social-preview.png)

## Overview

After [**Spectrum Icons**](static/image/spectrum-legacy.png) was removed from
After [**Spectrum Icons**](static/spectrum-legacy.png) was removed from
GitHub and the Visual Studio Marketplace, I meticulously crafted this icon theme
to be its successor.

Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 8 additions & 4 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
{
"publisher": "lewxdev",
"name": "vscode-glyph",
"version": "0.1.2",
"preview": true,
"version": "0.2.0",
"displayName": "%displayName%",
"description": "%description%",
"icon": "static/image/icon.png",
"icon": "static/icon.png",
"repository": "github:lewxdev/vscode-glyph",
"license": "MIT",
"engines": {
Expand Down Expand Up @@ -33,10 +32,15 @@
],
"contributes": {
"iconThemes": [
{
"id": "glyph.legacy",
"label": "%iconThemeLabelLegacy%",
"path": "theme/legacy-icon-theme.json"
},
{
"id": "glyph.minimal",
"label": "%iconThemeLabelMinimal%",
"path": "./theme/minimal-icon-theme.json"
"path": "theme/minimal-icon-theme.json"
}
]
},
Expand Down
1 change: 1 addition & 0 deletions package.nls.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"displayName": "Glyph for vscode",
"description": "A minimal icon theme for vscode inspired by Spectrum Icons by Alex Perronnet",
"iconThemeLabelLegacy": "Glyph (Legacy)",
"iconThemeLabelMinimal": "Glyph (Minimal)"
}
File renamed without changes
Binary file removed static/image/social-preview.png
Binary file not shown.
Binary file added static/social-preview.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
File renamed without changes
2 changes: 1 addition & 1 deletion theme/icons/dark/gear.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
File renamed without changes
2 changes: 1 addition & 1 deletion theme/icons/light/gear.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading

0 comments on commit 79354ca

Please sign in to comment.