Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove header magic #357

Merged
merged 2 commits into from
May 19, 2022
Merged

Remove header magic #357

merged 2 commits into from
May 19, 2022

Conversation

Anaphory
Copy link
Collaborator

Fixes #356

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #357 (be5937f) into master (b2bfdf1) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #357   +/-   ##
=======================================
  Coverage   80.78%   80.78%           
=======================================
  Files          43       43           
  Lines        4305     4305           
  Branches     1080     1081    +1     
=======================================
  Hits         3478     3478           
  Misses        633      633           
  Partials      194      194           
Impacted Files Coverage Δ
src/lexedata/util/excel.py 90.00% <ø> (-0.09%) ⬇️
src/lexedata/importer/excel_long_format.py 89.49% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2bfdf1...be5937f. Read the comment docs.

@Anaphory Anaphory merged commit 1aaa4ff into master May 19, 2022
@Anaphory Anaphory deleted the fix-356 branch May 19, 2022 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existing columns in excel file reported as missing during importation
1 participant