Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements on cognate set detection #369

Merged
merged 15 commits into from
Jun 9, 2022

Conversation

Anaphory
Copy link
Collaborator

@Anaphory Anaphory commented Jun 8, 2022

Also the final fixes for multiple languages in one long format table.
Sorry that my feature branches are so messy.

@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #369 (4c565b6) into master (fced3f3) will increase coverage by 0.23%.
The diff coverage is 91.57%.

@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   80.99%   81.23%   +0.23%     
==========================================
  Files          43       43              
  Lines        4326     4412      +86     
  Branches     1098     1129      +31     
==========================================
+ Hits         3504     3584      +80     
- Misses        629      632       +3     
- Partials      193      196       +3     
Impacted Files Coverage Δ
src/lexedata/importer/excel_long_format.py 89.44% <83.33%> (-0.60%) ⬇️
src/lexedata/edit/detect_cognates.py 59.78% <92.77%> (+26.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fced3f3...4c565b6. Read the comment docs.

@Anaphory Anaphory merged commit a719a9e into master Jun 9, 2022
@Anaphory Anaphory deleted the multi-languages-in-one-table branch June 9, 2022 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant