Made values from data/maybe and data/either serializable #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
At first glance, this looks good and reasonable, though I admit I’m not sure of the downsides of this (and if there are any at all). These datatypes seem like obvious candidates for being serializable, so I’ll probably merge this. Just give me a small bit of time to investigate the details (since I’ve never really used |
|
Hi, just thought I'd check on this. I've been using essentially these serializable versions of maybe and either in my own code without problems, so if you have any questions I'm happy to answer as best I can. |
|
Thanks for pinging me about this, I had forgotten about it! Merged in e1ed01a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with racket/serialize