Applicative-apply should return an applicative #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular, the examples for the `id` applicative and monad should return `id` instances from `apply`.
1 similar comment
|
This changes the documentation, but it does not change what a "proper" implementation of the applicative interface is. The test in tests/data/applicative.rkt stays the same; this PR only changes the documentation to follow that. I don't know why coverage went down so much when I didn't change any tests or add any new lines of code. |
|
Thanks for this! Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, the examples for the
idapplicative and monad should returnidinstances fromapply.(define (apply f xs) (id (base:apply (id-val f) (base:map id-val xs))))