Skip to content
This repository has been archived by the owner on Jan 12, 2023. It is now read-only.

Notes list shows externally added files with wrong extensions and hidden files #33

Closed
robwalton opened this issue Apr 2, 2018 · 2 comments
Assignees
Labels

Comments

@robwalton
Copy link
Contributor

I have the atom-ctags extension installed. This automatically creates .tags files in my notes directory which then show up in the notes view. As an experiment I also manually added files with the wrong file extension in there too and those also show up.

In the code:
notes-fs.isNote() seems to exclude these files
notes-store.setUpFileWatcher() adds all files regardless of file extension to the NotesStore

I'll make a pull request, but I'm not confident in this area of the code.

@lexicalunit
Copy link
Owner

No worries, I can review your PR too :)

@lexicalunit
Copy link
Owner

Resolved by #32!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants