This repository has been archived by the owner on Aug 25, 2018. It is now read-only.
Add two catalog operations: list_catalogs and list_schemas #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1469,6 +1469,10 @@ class catalog | |||
| , const string_type& schema = string_type() | |||
| , const string_type& catalog = string_type()); | |||
|
|
|||
| std::list<string_type> list_catalogs(); | |||
There was a problem hiding this comment.
Yea, I rushed too much. I will add some.
|
Looks pretty straightforward, just have one comment about missing Doxygen documentation for the new methods. Otherwise 👍 |
Both functions query data source using ODBC API call SQLTable: list_catalogs with SQL_ALL_CATALOGS to get list of valid catalogs. list_schemas with SQL_ALL_SCHEMAS to get list of valid schemas.
|
Docs updated. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both functions query data source using ODBC API call SQLTable:
list_catalogswith `SQL_ALL_CATALOGS to get list of valid catalogs.list_schemaswithSQL_ALL_SCHEMASto get list of valid schemas.Important detail to note is that the current
nanodbc::cataloglook-up functions have not been testedin the Identifier Arguments mode, so it is (implicitly) assumed the connection/statement attribute
SQL_ATTR_METADATA_IDisSQL_FALSE.There is number of quirks related to use of
SQLTables, so it is worth to have a look at these pages to get better understanding: