Add catalog::find_table_privileges function #204
Conversation
| @@ -100,6 +100,8 @@ TEST_CASE_METHOD(mysql_fixture, "catalog_tables_test", "[mysql][catalog][tables] | |||
| catalog_tables_test(); | |||
| } | |||
|
|
|||
| // TODO: Add catalog_table_privileges_test - SQLTablePrivileges returns empty result set | |||
There was a problem hiding this comment.
I have tried to call SQLTablePrivileges with variety of arguments (e.g. database name, empty database name, SQL_NTS or 0 for size, etc.) and this function always returns nothing. I have no idea why.
I'm using MySQL ODBC 5.3 Driver.
There was a problem hiding this comment.
I'd be ok with noting this issue in the documentation somewhere and omitting this test in MySQL.
There was a problem hiding this comment.
After merging, I'll try to look at it again and if still w/o luck, I'll document it.
|
Looks good! After rebasing on master, running the code style formatter, and add verifying the test pass again you're good to merge 👍 |
|
BTW, I also removed TODO comments: Translate "YES","NO", strings to enum I think it is better to stick to string values: 1) all catalog values are fetched as strings 2) some (buggy?) drivers may use driver-specific values, then we would be covered. Tread off: from user's perspective, enums offered by nanodbc would be a convenient simplification of ODBC interface. |
Add catalog::table_privileges result set. It is convenient wrapper for ODBC API call SQLTablePrivileges and its result set.
Add
catalog::table_privilegesresult setIt is convenient wrapper for ODBC API call
SQLTablePrivilegesand its result set.