Skip to content
This repository has been archived by the owner on Aug 25, 2018. It is now read-only.

Fixed retrieving long strings from MySQL #212

Merged
merged 6 commits into from
Nov 6, 2016

Conversation

saur0n
Copy link

@saur0n saur0n commented Sep 30, 2016

For some reasons, nanodbc does not properly bind and retrieve long strings from/to MySQL (MariaDB). It cuts this strings to first 128 bytes. blob_test() does not cover this bug.
#216

@mloskot
Copy link
Contributor

mloskot commented Oct 3, 2016

The test is failing on both, Linux (Travis CI job 629.3) and Windows (AppVeyor job 1.0.303)

@saur0n
Copy link
Author

saur0n commented Oct 3, 2016

Yes, I will try to bring fix for nanodbc (not for test) this week.

@saur0n saur0n changed the title Added test for MySQL long strings Fixed retrieving long strings from MySQL Nov 4, 2016
@saur0n
Copy link
Author

saur0n commented Nov 5, 2016

All tests passed successfully.

Copy link
Owner

@lexicalunit lexicalunit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @mloskot, your thoughts?

@mloskot
Copy link
Contributor

mloskot commented Nov 6, 2016

I'm travelling until the 13th of Nov, without laptop so can't really review
it. But, if all the current tests pass and the fix is covered with a test
too, sounds good to me.

When I'm back, I'll continue with bind functions refactoring. So better if
we merge pending PRs since the refactoring may be a bit intrusive.

On 6 Nov 2016 00:12, "Amy Troschinetz" notifications@github.com wrote:

@lexicalunit approved this pull request.

LGTM! @mloskot https://github.com/mloskot, your thoughts?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#212 (review),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAE7ZWblWoay2abwna52PxbChYQnIB1xks5q7Q1zgaJpZM4KLdjZ
.

@lexicalunit lexicalunit merged commit 547c3de into lexicalunit:master Nov 6, 2016
@mloskot mloskot added the bug label Nov 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants