Implement batch binary inputs #219
Conversation
|
Tests seem to be working for everything but MS-SQL, I will try and figure out what needs to change tomorrow, if you have any idea what might be wrong let me know. |
| } | ||
| } | ||
| bind_parameter(param, binary_data_[param].data(), elements, data_type, param_type, max_len, scale); | ||
| } |
There was a problem hiding this comment.
Can you convert to 4 spaces for indention before finalizing the PR?
|
@jimhester unfortunately I have the least amount of experience of all with MSSQL. Thank you for looking into it and all your effort improving this library :) |
jimhester
force-pushed
the
batch_binary
branch
from
934ed55
to
b4bb45f
Compare
|
Tests now passing, MS-SQL must need a default size for varbinary, or have a default less than 4. |
|
@jimhester Sorry for the PITA and braking your PR ;-) I'm going to submit PR fixing the conflicts. |
jimhester
force-pushed
the
batch_binary
branch
from
9289e43
to
5a69b5c
Compare
Also fix a test failure with PostgreSQL
|
LGTM. I take @lexicalunit 's #219 (comment) as approval notice. @jimhester are you still working on it or is it ready to merge? |
|
It is ready if it looks good to you! |
Similar to #214 this adds binding support for
std::vector<std::vector<uint8_t>>inputs, which allows you to bind batches of arbitrary binary data. We could not use thebind_strings()for this as there could be embedded nulls in the data, as pointed out by https://github.com/lexicalunit/nanodbc/issues/209.