Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop PHP <7.1 and Symfony <5.3 support #1056

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Drop PHP <7.1 and Symfony <5.3 support #1056

merged 1 commit into from
Aug 18, 2022

Conversation

wouter-toppy
Copy link
Contributor

Fix for #996

For tag 3.x

@chalasr
Copy link
Collaborator

chalasr commented Aug 10, 2022

Awesome! Thanks for working on this @wouter-toppy.

@wouter-toppy
Copy link
Contributor Author

@chalasr still trying to test and fix the ci

@chalasr
Copy link
Collaborator

chalasr commented Aug 10, 2022

Looks good to me. I'll merge this very soon and send a follow-up PR to remove the whole security-guard integration.

@wouter-toppy
Copy link
Contributor Author

@chalasr tests completed. and on my part the issue is resolved

@wouter-toppy
Copy link
Contributor Author

wouter-toppy commented Aug 12, 2022

@chalasr any idea when i can expect this to be merged (and tagged in 3.x)
Dont know if you still have other pulls/issues you want to merge into the 3.x branch

the JWTRefreshTokenBundle Pull is merged already, and hopefully gets a tag soon.

after that this is the only thing that blocks our WMS upgrade to Symfony 6.1 and PHP 8.1. because we can't enable preloading because of the original issue of this pull

@chalasr chalasr changed the base branch from 2.x to 3.x August 18, 2022 15:47
@chalasr
Copy link
Collaborator

chalasr commented Aug 18, 2022

Thank you @wouter-toppy.

@chalasr chalasr merged commit 49853cf into lexik:3.x Aug 18, 2022
@chalasr
Copy link
Collaborator

chalasr commented Aug 18, 2022

Note that I'm not going to tag 3.0 now, there is quite a lot of cleanup and work ongoing on 2.x before I can (should happen at some point by the end of the year). Of course meanwhile you can require the 3.x-dev version or some commit hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants