Fix ci 2.x #1115
Merged
Fix ci 2.x #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhelias
commented
Feb 10, 2023
chalasr
reviewed
Feb 10, 2023
maxhelias
force-pushed
the
fix-ci-2.x
branch
2 times, most recently
from
6917646
to
d53b843
Compare
|
Thanks for fixing this bug @maxhelias. |
|
Hey @chalasr. When do you plan to make 2.18.1 with this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1114 and all CI.
PHP 7.1 and symfony 4.4 cannot be tested in the CI but are still supported. Mainly because of the tests that need the browser-kit 5.4 at least and interface compatibility (without/with typing)
@chalasr after merge this, I would like a rebase on 3.x so that I can rework my other PR : #1108