Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation symfony 6.3 #1120

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

maxhelias
Copy link
Contributor

This is to remove deprecation notices on the Symfony 6.3 CI and adding this type should not break the bundle because all of them are on internal elements

Copy link
Collaborator

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LaYoance
Copy link

Thanks !

Inside the Lexik\Bundle\JWTAuthenticationBundle\Security\Authenticator

Symfony\Component\Security\Http\Authenticator\Passport\PassportInterface does not exists anymore since SF 6.0
You should use directly Symfony\Component\Security\Http\Authenticator\Passport\Passport instead

@maxhelias
Copy link
Contributor Author

maxhelias commented Feb 22, 2023

@LaYoance Yes but it's only used for the compatibility of createAuthenticatedToken method. This is not a problem in this configuration, but if we change it, it will break the compatibility with the interface.

And this method will be removed in the near future because it is depreciated.

@LaYoance
Copy link

Well, I understand that.

An old class in our project was using it. I've updated it on my side to match the new one.

Thanks

@chalasr
Copy link
Collaborator

chalasr commented Mar 1, 2023

Good catch, thanks Maxime.

@chalasr chalasr merged commit aa0bf3d into lexik:2.x Mar 1, 2023
@maxhelias maxhelias deleted the remove-deprecation-sf-63 branch March 1, 2023 12:07
@mickverm
Copy link

mickverm commented May 2, 2023

Symfony 6.3.0-BETA1 has been released, any chance this change could also make it to a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants