Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty or null authorization header prefix, closes #310 #311

Merged
merged 1 commit into from
Feb 28, 2017
Merged

Handle empty or null authorization header prefix, closes #310 #311

merged 1 commit into from
Feb 28, 2017

Conversation

quentin-st
Copy link
Contributor

This PR handles cases where token_extractors.authorization_header.prefix is null (~) or empty ("")

token_extractors:
    authorization_header:
        prefix: ~
        name: X-Auth-Token

@quentin-st
Copy link
Contributor Author

@chalasr : should we use a strict comparison ($this->prefix === null || $this->prefix === '') instead?

@chalasr
Copy link
Collaborator

chalasr commented Feb 28, 2017

@chteuchteu Fine as is.
Could you update the property+constructor argument doc block to allow string|null for $prefix?

@chalasr chalasr added the Bug label Feb 28, 2017
@chalasr
Copy link
Collaborator

chalasr commented Feb 28, 2017

Could you please take care of the StyleCI failure? Also rebase this on our 1.x branch?

@chalasr chalasr changed the base branch from master to 1.x February 28, 2017 11:37
@chalasr chalasr changed the base branch from 1.x to master February 28, 2017 11:37
@chalasr
Copy link
Collaborator

chalasr commented Feb 28, 2017

Thank you @chteuchteu

@chalasr chalasr merged commit 60c0c7b into lexik:master Feb 28, 2017
@quentin-st quentin-st deleted the empty-header-prefix branch February 28, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@quentin-st @chalasr