Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response classes shouldn't have the @internal PhpDoc tag #408

Closed
wants to merge 2 commits into from
Closed

Response classes shouldn't have the @internal PhpDoc tag #408

wants to merge 2 commits into from

Conversation

lashae
Copy link
Contributor

@lashae lashae commented Nov 3, 2017

@lashae
PhpDoc @internal is removed
fb58c68 
Since this class is to be implemented on on_jwt_invalid event, shouldn't have the @internal tag.
@lashae
PhpDoc @internal is removed
7218282 
Since this class is to be implemented on on_authentication_success event, shouldn't have the @internal tag.
@lashae lashae mentioned this pull request Nov 3, 2017
Closed
@chalasr
Copy link
Collaborator

chalasr commented Nov 4, 2017

Thank you @lashae.

chalasr added a commit that referenced this pull request Nov 4, 2017
@chalasr
bug #408 Response classes shouldn't have the @internal PhpDoc tag (la…
0a7a5e7 
…shae)

This PR was submitted for the master branch but it was squashed and merged into the 2.4 branch instead (closes #408).

Discussion
----------

Response classes shouldn't have the @internal PhpDoc tag

#407

Commits
-------

a4addae PhpDoc @internal is removed
36da1eb PhpDoc @internal is removed
@chalasr
Copy link
Collaborator

chalasr commented Nov 4, 2017

Merged in 2.4 branch.

@chalasr chalasr closed this Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lashae @chalasr