Allow setting the "exp" claim from event listeners #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have the same problem... Could you accept this PR? |
|
I'm 👍 to allow setting the exp claim (bypassing the configuration). But I think that if I set it from an event listener, I expect the value to not be changed later, I mean not adding the configured ttl. |
chalasr
requested changes
Jul 11, 2018
| @@ -86,7 +86,7 @@ public function create(array $payload, array $header = []) | |||
| $claims = ['iat' => time()]; | |||
|
|
|||
| if (null !== $this->ttl) { | |||
| $claims['exp'] = time() + $this->ttl; | |||
| $payload['exp'] = (isset($payload['exp']) ? $payload['exp'] : time()) + $this->ttl; | |||
There was a problem hiding this comment.
I would just not touch it if it is set
|
ping @MaximeMaillet :) |
chalasr
force-pushed
the
issues-441
branch
3 times, most recently
from
c22f42c
to
df16d4b
Compare
chalasr
changed the title
chalasr
approved these changes
Oct 5, 2018
|
Thank you @MaximeMaillet. |
This was referenced Nov 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related in #441