add ChainUserProvider #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
May 31, 2020
|
Thanks for fixing this bug @Gemorroj. |
CvekCoding
reviewed
Jun 19, 2020
Comment on lines
+290
to
+291
| foreach ($userProvider->getProviders() as $provider) { | ||
| if ($provider instanceof PayloadAwareUserProviderInterface) { |
There was a problem hiding this comment.
It's better to wrap this part into try-catch like it's done in original Chain provider https://github.com/symfony/security/blob/9b4060f040be91d55db67831bf83981097c609b1/Core/User/ChainUserProvider.php#L52
There was a problem hiding this comment.
@CvekCoding good catch. Would you mind sending a PR or shall I do it?
There was a problem hiding this comment.
@chalasr when this fix can be released?
There was a problem hiding this comment.
@CvekCoding it has been released in https://github.com/lexik/LexikJWTAuthenticationBundle/releases/tag/v2.8.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #615
Fixes #754