Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony 4.4/5.0 compatibility #689

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Symfony 4.4/5.0 compatibility #689

merged 1 commit into from
Nov 22, 2019

Conversation

Deuchnord
Copy link

#hackdayParis

@Deuchnord
Copy link
Author

Having a weird issue with the event dispatcher, both on v4.4 and v5.0, when running the tests:

Lexik\Bundle\JWTAuthenticationBundle\Tests\DependencyInjection\LexikJWTAuthenticationExtensionTest::testEncoderConfiguration
Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "lexik_jwt_authentication.security.authentication.provider" has a dependency on a non-existent service "event_dispatcher".

Tried to add symfony/event-dispatcher in the dev dependencies, but didn’t fix it.

Plus, I have two failing tests on my laptop, which seem to pass on the CI, and I don’t get why.

Failed asserting that exception message 'Failed to load public key: 
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line
 0909006C:PEM routines:get_name:no start line' contains '0906D06C:PEM routines:PEM_read_bio:no start line'.

2) Lexik\Bundle\JWTAuthenticationBundle\Tests\Services\KeyLoader\OpenSSLKeyLoaderTest::testLoadInvalidPrivateKey
Failed asserting that exception message 'Failed to load private key: 
 0909006C:PEM routines:get_name:no start line' contains '0906D06C:PEM routines:PEM_read_bio:no start line'.

Is it possible that’s related to my version of OpenSSL (OpenSSL 1.1.1d 10 Sep 2019)?

@chalasr WDYT?

chindit
chindit reviewed Nov 13, 2019
View reviewed changes
composer.json Outdated
@@ -5,6 +5,7 @@
"keywords": ["Symfony", "bundle", "jwt", "jws", "authentication", "api", "rest"],
"homepage": "https://github.com/lexik/LexikJWTAuthenticationBundle",
"license": "MIT",
"minimum-stability": "dev",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it's a good idea to change this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's only to allow me working with Symfony 4.4 and Symfony 5 that have not been released yet. Once done, I'll remove it ;)

@chalasr chalasr marked this pull request as ready for review November 21, 2019 17:22
@sergiu-popa
Copy link

How did you install it for Symfony 5?

Problem 1
- lexik/jwt-authentication-bundle v2.6.4 requires symfony/framework-bundle ^3.4|^4.0 -> no matching package found.

@chalasr chalasr force-pushed the upgrade-sf5 branch 4 times, most recently from 5016774 to 41a05c6 Compare November 22, 2019 07:18
@chalasr chalasr changed the title Upgrade Symfony to 5.0 Symfony 4.4/5.0 compatibility Nov 22, 2019
@chalasr chalasr force-pushed the upgrade-sf5 branch 3 times, most recently from e6190ce to 1c8fb06 Compare November 22, 2019 13:51
@chalasr
Copy link
Collaborator

chalasr commented Nov 22, 2019

Thank you @Deuchnord.

chalasr added a commit that referenced this pull request Nov 22, 2019
@chalasr
bug #689 Symfony 4.4/5.0 compatibility (Deuchnord)
2311f63 
This PR was merged into the 2.x-dev branch.

Discussion
----------

Symfony 4.4/5.0 compatibility

#hackdayParis

Commits
-------

3a44f4f Symfony 4.4/5.0 compatibility
@chalasr chalasr merged commit 3a44f4f into lexik:master Nov 22, 2019
@chindit
Copy link

chindit commented Nov 22, 2019

Thanks @chalasr and @Deuchnord for your work on this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chindit chindit chindit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Deuchnord @sergiu-popa @chalasr @chindit