Test against symfony 5.1 and fix deprecations #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
force-pushed
the
fix-symfony-51-setdeprecated-deprecation
branch
2 times, most recently
from
0bf714a
to
831b784
Compare
acrobat
force-pushed
the
fix-symfony-51-setdeprecated-deprecation
branch
from
8d65b4d
to
93662ed
Compare
acrobat
changed the title
acrobat
force-pushed
the
fix-symfony-51-setdeprecated-deprecation
branch
from
c15b157
to
93662ed
Compare
chalasr
approved these changes
May 31, 2020
chalasr
force-pushed
the
fix-symfony-51-setdeprecated-deprecation
branch
from
93662ed
to
4ca47ac
Compare
|
Great! Thank you @acrobat. |
|
Thanks a lot! Will it be possible to release a patch version soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix this deprecation I had to bump the minimum supported php version to 5.6.
I don't know what the policy is on supporting php versions, but php 5.5 is EOL for a long time now so I guess this is ok to do?
This pr now fixes also other symfony 5.1 deprecations