Changed JWTAuthenticator::start method return type to more generic Response type
#905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aurimasniekis
changed the title
JWTAuthenticator::start method return type to more generic Response` typeJWTAuthenticator::start method return type to more generic Response type
chalasr
approved these changes
Aug 14, 2021
|
I am not sure about |
|
Don’t worry about it, it’s not related |
|
Thanks for fixing this bug @aurimasniekis. |
|
Just encounter this issue on today. I think this patch should be release as soon as possible otherwise it breaks current project that have custom response after upgrade. How do you think? @chalasr |
|
Thanks for the ping! I will draft the release tonight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not a big change just fixes an issue where the old code is upgraded to use the new JWTAuthenticator.
This fixes #904