Add remove_token_from_body_when_cookies_used config option
#940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, is there something that is blocking this PR? If so, please let me know and I will make the required modifications. |
chalasr
approved these changes
Nov 14, 2021
|
This looks good. I'm going to merge it a bit later this month. Thank you! |
chalasr
changed the title
remove_token_from_body_when_cookies_used config option
|
Thank you @TjorvenB. |
chalasr
added a commit
that referenced
this pull request
Dec 11, 2022
…_when_cookies_used` (usu) This PR was merged into the 2.x branch. Discussion ---------- allow environment variables for `remove_token_from_body_when_cookies_used` #940 introduced a new config option to enable response body when cookies are used: ```yaml remove_token_from_body_when_cookies_used: false ``` However, currently environment variables cannot be used to control this config. An error `Environment variables "bool:JWT_REMOVE_TOKEN_FROM_BODY" are never used` is thrown. After this PR, this option can also be used as following: ```yaml remove_token_from_body_when_cookies_used: '%env(bool:JWT_REMOVE_TOKEN_FROM_BODY)%' ``` Commits ------- 376db99 allow environment variables for remove_token_from_body_when_cookies_used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added configuration and documentation for the argument added in #912. #912