Add custom authorization header name #96
Conversation
| */ | ||
| public function __construct($prefix) | ||
| public function __construct($prefix, $name) |
There was a problem hiding this comment.
It would be safer to set a default value of 'Autorization' for the $name argument, to prevent any BC break.
There was a problem hiding this comment.
Default $name is set in JWTFactory.php, the same way default $prefix is defined
|
Hi, nice addition for special cases. |
pdoreau
force-pushed
the
custom-auth-header-name
branch
from
1b29147
to
19979de
Compare
pdoreau
force-pushed
the
custom-auth-header-name
branch
from
19979de
to
f609bc9
Compare
| */ | ||
| public function __construct($prefix) | ||
| public function __construct($prefix, $name) |
There was a problem hiding this comment.
Again, I think there should be a default value for the $name parameter, even if it is overwritable by the dependency injector like any other argument. The class is called AuthorizationHeaderTokenExtractor, so it would make sense to have it "preconfigured" for this header name.
Maybe a constant DEFAULT_HEADER_NAME = 'Authorization' and a constructor like __construct($prefix, $name = self::DEFAULT_HEADER_NAME).
In a future major version, the class could be renamed to HeaderTokenExtractor.
Add custom authorization header name
Hi, I need double authentication : HTTP basic for general restriction and JWT at API level.
They both used the same header (Authorization).
This PR allows to use a custom header name for JWT token in order to handle double authentication.