Skip to content
This repository has been archived by the owner on Mar 15, 2024. It is now read-only.

Allow Symfony ^4.0 #94

Merged
merged 7 commits into from
Jan 17, 2019
Merged

Allow Symfony ^4.0 #94

merged 7 commits into from
Jan 17, 2019

Conversation

yann-eugone
Copy link
Contributor

@yann-eugone yann-eugone commented Jan 8, 2019

Please let me know if there is something else I can do to help.

@yann-eugone
Copy link
Contributor Author

yann-eugone commented Jan 15, 2019

I do not know your compatibility strategy so I tried to update Travis matrix to test everything, look like it is harder than expected, specialy because phpunit version is not required.

Can someone tell me how you want me to fix this ?

@gilles-g
Copy link
Member

@yann-eugone
Hi,
Have a look on https://github.com/lexik/LexikJWTAuthenticationBundle/blob/master/.travis.yml

The strategy is to test for each php version, each symfony version

Maybe change the phpunit requirements for something like that "symfony/phpunit-bridge": "^3.4|^4.0",

@yann-eugone
Copy link
Contributor Author

Maybe it is just me, but do you think that testing something like PHP 7.3 Symfony 2.7 is a good idea ?

@yann-eugone
Copy link
Contributor Author

Tests are green, I had to replace symfony/phpunit-bridge with phpunit/phpunit to be sure of PHPUnit version

@gilles-g
Copy link
Member

@yann-eugone look at this lines

https://github.com/lexik/LexikJWTAuthenticationBundle/blob/master/.travis.yml#L5-L13

We don't want to test php 7.3 with sf 2.7

Ah I understand, I said each php version for each sf version. It was a mistake :)

@yann-eugone
Copy link
Contributor Author

Green again, matrix took ~11 minutes (instead of ~45 minutes previously) to run

@gilles-g gilles-g merged commit 46a85d8 into lexik:master Jan 17, 2019
@gilles-g
Copy link
Member

gilles-g commented Jan 17, 2019

Nice job!
I will create a release

@yann-eugone yann-eugone deleted the symfony4 branch January 17, 2019 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants