Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix render twig in controller for overriding purpose #311

Merged
merged 1 commit into from Aug 25, 2018

Conversation

bricejulia
Copy link
Contributor

No description provided.

@pmontoya
Copy link

👍

@ankhzet
Copy link

ankhzet commented Jun 1, 2018

@bricejulia, please, resolve conflicts in pull request.
Without this fix it's almost impossible to override bundle's templates in Symfony 3.4 (I can't figure other way than overriding actions in controller) >_<.

Also, it would fix #323

@noniagriconomie
Copy link

@spike31 any news for this one? Thank you

@DanieleGBX
Copy link

DanieleGBX commented Aug 24, 2018

I do realize how annoying having people insist might be, but this PR is solving some critical bugs that are making using this bundle impossible. @spike31 would it be possible to merge this and release it?

@gilles-g gilles-g merged commit 99fba02 into lexik:master Aug 25, 2018
@ankhzet
Copy link

ankhzet commented Aug 25, 2018

Thank you!

WL-arek pushed a commit to wlogic/LexikTranslationBundle that referenced this pull request Mar 29, 2021
* lexik/3.4:
  Fix travis for 3.4 (lexik#376)
  Add Symfony 4.3 kernel.locale_aware tag (lexik#347)
  Sf4 fix (lexik#331)
  Update LexikTranslationBundle.es.yml (lexik#339)
  class names are declared in StudlyCaps (lexik#328)
  🐛 Fix render twig in controller for overriding purpose (lexik#311)
  Fix BC with Symfony 2.8 LTS (lexik#322)
  add sf4 support (lexik#320)
  Added modified flag in order to fix merge algorithm (lexik#261)
  Remove useless check on http method (lexik#315)
  Corrected ExportTranslationsCommand service id. (lexik#314)
  Fix symfony >= 3.4 user deprecated. (lexik#310)
  lexik#306. set public of 'translate' alias for compatibility with other components in SF4. (lexik#309)
  Symfony 4 support (lexik#305)
  Minor typo fixes (lexik#296)
  Replace Propel to Propel2. (lexik#302)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants