Allow users to specify a custom HttpURLConnection. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in issue lexs#11, this allows the use of libraries like OkHttp to work around various native Android HTTP bugs.
Closed
|
Sorry for not answering sooner. This is pretty close to what I had in mind. I want to still keep ConnectionHandler as is (for compatiability) and introduce a new class instead. I'll probably deprecate ConnectionHandler though. I'll code this up over the weekend hopefully :) |
|
Implemented in f605225. Same idea but I decided on using a separate interface. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #11, this allows the use of libraries like OkHttp to work around various native Android HTTP bugs.
I don't know if these changes were exactly what you were thinking of, but this works well for me (with a patched version of OkHttp which properly handles HTTP 307 redirects).
I tested it with no
ConnectionHandler, a handler which always returnsnulland a handler which uses OkHttp. Everything worked as expected.