Enhance controller spec type setup

No longer need to set up and pass in the stage variable, or manually set
the type when the specs are in the controllers folder.

spec/lib/launchpad/gui/controllers/main_controller_spec.rb

@@ -1,9 +1,6 @@
 require 'spec_helper'
 
-describe Launchpad::MainController, type: :controller do
-  subject { described_class.new stage: stage_double }
-
-  let(:stage_double) { double 'stage', on_shown: true }
+describe Launchpad::MainController do
 
   before { allow(Launchpad::UpdateManager).to receive :new }
 

spec/lib/launchpad/gui/controllers/options_controller_spec.rb

@@ -1,10 +1,6 @@
 require 'spec_helper'
 
-describe Launchpad::OptionsController, type: :controller do
-  subject { described_class.new stage: stage_double }
-
-  let(:stage_double) { double 'stage', on_shown: true, close: true }
-
+describe Launchpad::OptionsController do
   let(:options) do
     [:install, :local_index_path, :remote_index_uri, :login_server, :port]
   end

spec/spec_helper.rb

@@ -4,19 +4,17 @@
 require 'pry' unless ENV['CI']
 require 'launchpad'
 require 'rspec'
+require 'support'
 
 RSpec.configure do |config|
   # Exit the javafx toolkit after running specs
   config.after(:suite) { JavaFXImpl::PlatformImpl.tkExit }
 
-  # Remove jrubyfx controller overrides and set the stage double
-  config.before(:example, type: :controller) do
-    described_class.define_singleton_method(:new) do |*args|
-      allocate.tap do |controller|
-        stage = args.last && args.last[:stage]
-        controller.instance_variable_set(:@stage, stage) if stage
-        controller.send :initialize
-      end
-    end
+  # Set type to controller for all specs in the controllers folder
+  config.define_derived_metadata(file_path: /controllers/) do |metadata|
+    metadata[:type] ||= :controller
   end
+
+  # Include the controller shared context for all controller specs
+  config.include Launchpad::RSpec::Controller, type: :controller
 end

spec/support.rb

@@ -0,0 +1 @@
+Dir.chdir('spec') { Dir['support/**/*.rb'].each { |file| require file } }

spec/support/controller.rb

@@ -0,0 +1,17 @@
+module Launchpad
+  module RSpec
+    # Remove the jrubyfx controller overrides and set the stage double.
+    module Controller
+      extend ::RSpec::SharedContext
+
+      let(:stage) { double 'stage', on_shown: true, close: true }
+
+      subject do
+        described_class.allocate.tap do |controller|
+          controller.instance_variable_set :@stage, stage
+          controller.send :initialize
+        end
+      end
+    end
+  end
+end