You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have tried to reproduce your hyperbolicity experiments with the cifar10 dataset, using the code in delta.py. I have stumbled across a potential error. In the paper you calculate the relative Hyperbolicity of a dataset by doing the following calculation:
δrel(X) = 2δ(X) / diam(X)
However, in the delta.py δ(X) is not multiplied by 2, giving incorrect results: delta_rel = delta_hyp(distmat) / diam
When I multiply by 2 it seems to work and I can reproduce the cifar10 hyperbolicity score:
delta_rel = (2 * delta_hyp(distmat)) / diam
Is this change correct?
The text was updated successfully, but these errors were encountered:
ajbanks
changed the title
Error in calculating Hyperbolicity?
Calculating Hyperbolicity bug in delta.py?
Aug 7, 2021
I have tried to reproduce your hyperbolicity experiments with the cifar10 dataset, using the code in delta.py. I have stumbled across a potential error. In the paper you calculate the relative Hyperbolicity of a dataset by doing the following calculation:
δrel(X) = 2δ(X) / diam(X)
However, in the delta.py δ(X) is not multiplied by 2, giving incorrect results:
delta_rel = delta_hyp(distmat) / diam
When I multiply by 2 it seems to work and I can reproduce the cifar10 hyperbolicity score:
delta_rel = (2 * delta_hyp(distmat)) / diam
Is this change correct?
The text was updated successfully, but these errors were encountered: