Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is it a bug in HyperbolicMLR? #15

Open
chenkq7 opened this issue Sep 5, 2022 · 0 comments
Open

is it a bug in HyperbolicMLR? #15

chenkq7 opened this issue Sep 5, 2022 · 0 comments

Comments

@chenkq7
Copy link

chenkq7 commented Sep 5, 2022

Thanks a lot for sharing your repo. I am new to hyperbolic neural networks, and I learned a lot from your repo.
While i am reading the code of examples/mnist.py, i am curious about why ToPoincare is only applied for x which is calculated by a neural network, whereas, ToPoincare is not applied for p_val in HyperbolicMLR.

p_vals_poincare = pmath.expmap0(self.p_vals, c=c)

consider that they are both need a expmap0 to map them from $R^2$ to $D^2$, won't p_val get a wrong gradient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant