feat: improve download_folder functionality
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GameTaco
commented
Sep 13, 2023
GameTaco
commented
- Add docstrings for entry and download functions.
- Separate file and directory handling loops for easier changes.
- Implement extra items check with a user confirmation prompt.
- Created print statements, and error handling.
- Update isort, and min python for incompatible poetry and pre-commit
- Added [tool.poetry.group.dev.dependencies] format for poetry
- Add docstrings for entry and download functions. - Separate file and directory handling loops for easier changes. - Implement extra items check with a user confirmation prompt. - Created print statements, and error handling. - Update isort, and min python for incompatible poetry and pre-commit - Added [tool.poetry.group.dev.dependencies] format for poetry
leynier
reviewed
Sep 13, 2023
| if exists(fullpath): | ||
| if force: | ||
| if extra_items: |
There was a problem hiding this comment.
I think that if the force is true the removal of the folder should be automatic, if it's false then ask to user if he/she wants to delete the folder and continue or cancel the operation. So:
if force:
...
elif extra_items:
...
else:
...
leynier
reviewed
Sep 13, 2023
| """ | ||
| fullpath = join(output, path) | ||
| existing_items = set(os.listdir(fullpath)) if os.path.exists(fullpath) else set() |
There was a problem hiding this comment.
from os import listdir, makedirs
...
existing_items = set(listdir(fullpath)) if exists(fullpath) else set()
leynier
changed the title
leynier
changed the title
download_folder functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.