test panic in logs #492
Merged
test panic in logs #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/vnc/vnc_test.go
Outdated
| return fmt.Errorf("SSH success. You can access it via SSH on %s:%d", externalIP, *sshPort) | ||
| } | ||
| } | ||
|
|
||
| //checkPanicInLog try to find panic in app log |
There was a problem hiding this comment.
Can we do a general function Check (message) in log and call it with string param (message) and move it to pkg?
Signed-off-by: Petr Fedchenkov <giggsoff@gmail.com>
giggsoff
force-pushed
the
vm-crash-test
branch
from
18f51d9
to
8191f58
Compare
|
This looks great, but I'm confused as to why does this have to do with VNC? We need these panic logs on the serial console, not VNC. What's going on @giggsoff ? |
|
We wait for panic messages inside logs of application, not in VNC. VNC test is just the place where we have VM and we can access it via ssh, VNC and read logs/infos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds flag to fire kernel panic and wait for logs with it inside vnc_test.
Signed-off-by: Petr Fedchenkov giggsoff@gmail.com