Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a github workflow to trigger push and PR workflow in order to check build failure #138

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Add a github workflow to trigger push and PR workflow in order to check build failure #138

merged 1 commit into from
Oct 6, 2020

Conversation

tiokim
Copy link
Contributor

@tiokim tiokim commented Oct 6, 2020

Signed-off-by: Taewan Kim t25.kim@samsung.com

Description

This PR enables the build test automatically through github actions.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  1. Push a commit to github
  2. Check the Actions tab on github

Result
image

Test Configuration:

  • Firmware version: Ubuntu 18.04
  • Hardware: x86-64
  • Toolchain: github actions
  • Edge Orchestration Release: Baobab

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@tiokim
Add a github workflow to trigger push and PR workflow in order to che…
f4ab5bd 
…ck build failure

Signed-off-by: Taewan Kim <t25.kim@samsung.com>
@MoonkiHong MoonkiHong added the enhancement New feature or request label Oct 6, 2020
MoonkiHong
MoonkiHong approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great!!! Thank you for your always great contributions!!! @t25kim

suresh-lc
suresh-lc approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@suresh-lc suresh-lc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and this would be of great help

@MoonkiHong MoonkiHong merged commit 7282977 into lf-edge:master Oct 6, 2020
@tiokim tiokim deleted the workflows branch October 6, 2020 12:01
@MoonkiHong MoonkiHong mentioned this pull request Oct 8, 2020
Closed
MoonkiHong added a commit that referenced this pull request Oct 8, 2020
@MoonkiHong
Update PULL_REQUEST_TEMPLATE.md w.r.t. the issue #139
c918a0a 
Signed-off-by: Peter Moonki Hong <moonki1.hong@samsung.com>
Co-authored-by: Taewan Kim <t25.kim@samsung.com>

Since we have setup the CI per every PR in terms of build verification through #138, we suggest to delete the existing notification from the PULL_REQUEST_TEMPLATE.md document to recommend a self verification of the build success/failure per every PR.
MoonkiHong added a commit that referenced this pull request Oct 12, 2020
@MoonkiHong
Merge pull request #140 from MoonkiHong/master
8906232 
Update CONTRIBUTING.md as applying the merged PR #138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoonkiHong MoonkiHong MoonkiHong approved these changes

@suresh-lc suresh-lc suresh-lc approved these changes

Assignees

@tiokim tiokim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tiokim @MoonkiHong @suresh-lc