Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the doc related to environment variables #170

Merged
merged 1 commit into from
Nov 9, 2020
Merged

Update the doc related to environment variables #170

merged 1 commit into from
Nov 9, 2020

Conversation

tiokim
Copy link
Contributor

@tiokim tiokim commented Nov 9, 2020

Signed-off-by: Taewan Kim t25.kim@samsung.com

Description

Update the doc related to environment variables.

Related Issue #168

Type of change

  • Documentation update
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Taewan Kim <t25.kim@samsung.com>
@MoonkiHong MoonkiHong added the documentation Improvements or additions to documentation label Nov 9, 2020
Copy link
Contributor

@MoonkiHong MoonkiHong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document updates for applying the build options. LGTM.

@tdrozdovsky
Copy link
Contributor

tdrozdovsky commented Nov 9, 2020

@MoonkiHong @t25kim The ability to configure the edge-orchestration from the command line makes it more flexible.
But enabling or disabling protection (without secure) makes the edge-orchestration more vulnerable, as it allows the user (hacker) to disable protection. As I said earlier, the operation of the edge-orchestration without protection should be temporary, only at the development stage (for simplicity), by default, the protection must be enabled.

You need to think again whether you need to use the ability to start the edge-orchestration without protection. If you have weighty arguments, please write to me.

Temporarily this solution may be, but I think in the future it will be necessary to revert to the previous version or cancel the ability to build without secure.

Please note that my assumption only applies to protected mode.

it is very important for me to hear your opinion on this request

@MoonkiHong
Copy link
Contributor

@MoonkiHong @t25kim The ability to configure the edge-orchestration from the command line makes it more flexible.
But enabling or disabling protection (without secure) makes the edge-orchestration more vulnerable, as it allows the user (hacker) to disable protection. As I said earlier, the operation of the edge-orchestration without protection should be temporary, only at the development stage (for simplicity), by default, the protection must be enabled.

You need to think again whether you need to use the ability to start the edge-orchestration without protection. If you have weighty arguments, please write to me.

Temporarily this solution may be, but I think in the future it will be necessary to revert to the previous version or cancel the ability to build without secure.

Please note that my assumption only applies to protected mode.

it is very important for me to hear your opinion on this request

@tdrozdovsky Understood that the secure mode is by default, but we are a long way to go. Anyway, the initial proposal to setup the secure mode is a separate option to build for it. As you suggested, this is a temporary version, but we need to clearly indicate that our regular release should be by default with the secure mode. Thought?

@tdrozdovsky But still even with secure mode by default, as you see our recent security analysis provided by LGTM, there are 17 alerts/issues that we need to fix for the secure operation. (Of course, most of them are for the debugging mode, but this is anyhow related to the security be design.) Hope to get your feedback further. (aside from evaluating this PR)

@tdrozdovsky
Copy link
Contributor

@MoonkiHong Yes, I completely agree with you, I just want us to remember this and not accept that this is a permanent decision. As I said, I like that we have flexibility in configuration.

@tiokim
Copy link
Contributor Author

tiokim commented Nov 9, 2020

@MoonkiHong @t25kim The ability to configure the edge-orchestration from the command line makes it more flexible.
But enabling or disabling protection (without secure) makes the edge-orchestration more vulnerable, as it allows the user (hacker) to disable protection. As I said earlier, the operation of the edge-orchestration without protection should be temporary, only at the development stage (for simplicity), by default, the protection must be enabled.

You need to think again whether you need to use the ability to start the edge-orchestration without protection. If you have weighty arguments, please write to me.

Temporarily this solution may be, but I think in the future it will be necessary to revert to the previous version or cancel the ability to build without secure.

Please note that my assumption only applies to protected mode.

it is very important for me to hear your opinion on this request

@tdrozdovsky Thank you very much for your valuable idea.
Please don't get this issue wrong. This item is intended to support the user convenience since building several edge-orchestration images is way too inefficient.
It would be good to write down to use secure mode for commercialization in the README file.

Copy link
Contributor

@suresh-lc suresh-lc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. By default Secure would be enabled as the conversations.

@MoonkiHong
Copy link
Contributor

LGTM. By default Secure would be enabled as the conversations.

@suresh-lc Just for a clarification, the current source code is not built as a secure mode by default, it is enabled by secure option. This PR is for a temporary approach before we get full features described by Wiki (all 4~5 modules). What we have discussed so far is: we would like to enable the secure mode by default in the future regular release for those who would like to commercialize their product with Home Edge.

@MoonkiHong MoonkiHong merged commit 324b41b into lf-edge:master Nov 9, 2020
@tiokim tiokim deleted the env branch November 9, 2020 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants