-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the doc related to environment variables #170
Conversation
Signed-off-by: Taewan Kim <t25.kim@samsung.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document updates for applying the build options. LGTM.
@MoonkiHong @t25kim The ability to configure the edge-orchestration from the command line makes it more flexible. You need to think again whether you need to use the ability to start the edge-orchestration without protection. If you have weighty arguments, please write to me. Temporarily this solution may be, but I think in the future it will be necessary to revert to the previous version or cancel the ability to build without secure. Please note that my assumption only applies to protected mode. it is very important for me to hear your opinion on this request |
@tdrozdovsky Understood that the @tdrozdovsky But still even with |
@MoonkiHong Yes, I completely agree with you, I just want us to remember this and not accept that this is a permanent decision. As I said, I like that we have flexibility in configuration. |
@tdrozdovsky Thank you very much for your valuable idea. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. By default Secure would be enabled as the conversations.
@suresh-lc Just for a clarification, the current source code is not built as a secure mode by default, it is enabled by |
Signed-off-by: Taewan Kim t25.kim@samsung.com
Description
Update the doc related to environment variables.
Related Issue #168
Type of change
How Has This Been Tested?
Checklist: