Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CWE-78, Command built from user-controlled sources #299

Closed
wants to merge 1 commit into from

Conversation

tiokim
Copy link
Contributor

@tiokim tiokim commented May 6, 2021

  • Checking the command and args before running a native application

Signed-off-by: Taewan Kim t25.kim@samsung.com

Description

Fix CWE-78, Command built from user-controlled sources

Fixes #298

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Run TC

$ go test -v ./internal/controller/servicemgr/executor/nativeexecutor

Test Configuration:

  • Firmware version: Ubuntu 20.04
  • Hardware: x86-64
  • Edge Orchestration Release: Coconut

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

- Checking the command and args before running a native application

Signed-off-by: Taewan Kim <t25.kim@samsung.com>
@sonarcloud
Copy link

sonarcloud bot commented May 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tiokim
Copy link
Contributor Author

tiokim commented May 6, 2021

Close this PR since this code is not enough to resolve the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security] CWE-78 Command built from user-controlled sources
1 participant